Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests suite working for every contributors #110

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ALanguillaume
Copy link
Member

Why:

  • For contributors who were not the maintainers the test suite was not passing. The tests expected some projects that were only created on the maintainer session. Despite, the script dev/create_testor_on_gitlab.R was creating only one project "testor.main".

How:

  • Test only the presence of testor projects define in the helpers by environment variable GITLABR_TEST_PROJECT_NAME

Why:

- For contributors who were not the maintainers the test suite was not
  passing. The tests expected some projects that were only created on
  the maintainer session. Despite, the script dev/create_testor_on_gitlab.R
  was creating only one project "testor.main".

How:

- Test only the presence of testor projects define in the helpers by
  environment variable `GITLABR_TEST_PROJECT_NAME`
@statnmap statnmap merged commit bd31578 into main Jan 17, 2024
7 checks passed
@statnmap statnmap deleted the fix-test-suite-contrib branch May 14, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants